tls: set client CA list based on the ca-dir() and ca-file() options #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
added a commit
to alltilla/syslog-ng
that referenced
this pull request
Apr 3, 2023
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
tls-set-client-CA-list
branch
from
a18b450
to
63f59b0
Compare
|
I know that this is yet another case, where sometimes the function is a NOOP, but it would be strange to see the preprocessor macros about the SSL functions being further away from the place they are actually called. |
MrAnno
reviewed
Apr 3, 2023
alltilla
added a commit
to alltilla/syslog-ng
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
tls-set-client-CA-list
branch
from
63f59b0
to
50a41ee
Compare
alltilla
added a commit
to alltilla/syslog-ng
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
tls-set-client-CA-list
branch
from
50a41ee
to
27e3b60
Compare
|
I have observed, that in case of failure the |
Filling the certificate_authorities field of the certificate request, to help clients choose certs to use. From https://www.ietf.org/rfc/rfc5246.txt 7.4.4: > certificate_authorities > A list of the distinguished names [X501] of acceptable > certificate_authorities, represented in DER-encoded format. These > distinguished names may specify a desired distinguished name for a > root CA or for a subordinate CA; thus, this message can be used to > describe known roots as well as a desired authorization space. If > the certificate_authorities list is empty, then the client MAY > send any certificate of the appropriate ClientCertificateType, > unless there is some external arrangement to the contrary. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
tls-set-client-CA-list
branch
from
27e3b60
to
6dda2a8
Compare
MrAnno
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filling the
certificate_authoritiesfield of the certificate request, to help clients choose certs to use.From https://www.ietf.org/rfc/rfc5246.txt 7.4.4:
Example:
Signed-off-by: Attila Szakacs attila.szakacs@axoflow.com